I have tried searching for something, (this is the result page)
Apparently, when the hilit function uses too common words, the server delivers non-readable junk where the standard spoiler marks should be. And you can click the "show" part of the spoiler, but you can't open the spoiler, as nothing happens.
When I change the address by deleting "too common" words in the hilit funtion, it works fine.
Just wanted to tell, as this could be an indication of a faulty implementation somewhere, which could lead to vulnerabilities regarding the server.
EDIT: a bit more testing: it only happens when you have the word "this" highlighted, as it appears in the code of the "spoiler" function.
"for" is no problem, neither "die".
Edit2: "else" is also a problem, but it looks different. Apparently, the search function searches in the code of tags too, and as many common words are used in programming languages too, this happens.... Functionnames are unlikely to be searched, but someone knowing a bit about phpBB might know more.
Problem with showing of search results
- Krulle
- Transcribes Goblins
- Posts: 8129
- Contact:
Problem with showing of search results
You do not have the required permissions to view the files attached to this post.
STAR CONTROL: The Ur-Quan Masters finally gets a continuation of the story!
it's fully funded, and all realistic stretch goals reached!
it's fully funded, and all realistic stretch goals reached!
- SeeAMoose
- Admin Moose on the Loose
- Posts: 1428
- UStream Username: See_a_Moose
- Location: Maryland (DC Area)
Re: Problem with showing of search results
Thanks for the heads up, I'll look into it.
I am one of the forum admins and chat moderators. Drop any of us a line if you ever need a hand in either the forum or the chat.
You can reach me at AdminMoose@goblinsforum.com or at BotWalter@gmail.com
You can reach me at AdminMoose@goblinsforum.com or at BotWalter@gmail.com
- Krulle
- Transcribes Goblins
- Posts: 8129
- Contact:
Re: Problem with showing of search results
A quick workaround would be to add these words to the "non-searchable or too common" list...
STAR CONTROL: The Ur-Quan Masters finally gets a continuation of the story!
it's fully funded, and all realistic stretch goals reached!
it's fully funded, and all realistic stretch goals reached!
- gamecreator
- Prattles on Unremittingly
- Posts: 3116
- Location: Ukraine
Re: Problem with showing of search results
That's really bad workaround. What if someone will want to search for a word "spoiler"? Or "style", "show" etc.?
- Krulle
- Transcribes Goblins
- Posts: 8129
- Contact:
Re: Problem with showing of search results
The very common words are already a problem.
It is a problem, but the safety of the forum should come first.
I also don't like the search facility of the forum, and often use google to search the forum (by adding "site: goblinsforum.com" to the google search statement). Google is good for string searches, which this forum search engine does not allow or do.Won't work in hidden thread, posts, or forums, alas.
And the "no string search" already limits the useability for me very much, as these are most effective when "short standard words" like "the", "this", or the like, not forbidden.
But maybe the phpBB people knwo about this problem, and made sure that this does not lead to vulnerabilities. Then there is no workaround necessary. Then it's just a problem with the highlighting function. And maybe this highlighting function needs some "forbidden words" then...
It is a problem, but the safety of the forum should come first.
I also don't like the search facility of the forum, and often use google to search the forum (by adding "site: goblinsforum.com" to the google search statement). Google is good for string searches, which this forum search engine does not allow or do.Won't work in hidden thread, posts, or forums, alas.
And the "no string search" already limits the useability for me very much, as these are most effective when "short standard words" like "the", "this", or the like, not forbidden.
But maybe the phpBB people knwo about this problem, and made sure that this does not lead to vulnerabilities. Then there is no workaround necessary. Then it's just a problem with the highlighting function. And maybe this highlighting function needs some "forbidden words" then...
STAR CONTROL: The Ur-Quan Masters finally gets a continuation of the story!
it's fully funded, and all realistic stretch goals reached!
it's fully funded, and all realistic stretch goals reached!